Update secp256k1 dependency #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In secp256k1-sys we replaced this feature with a cfg flag back in rust-bitcoin/rust-secp256k1#263 ... here we got rid of the feature but retained the feature-gate, making the functionality useless. While we are at it, whitelist the cfg flags that we _do_ use.
apoelstra
force-pushed
the
2024-06--secp-29
branch
from
b827740 to
4fb4de3
Compare
|
Is this going to be merged and released soon? |
jonasnick
approved these changes
Jul 2, 2024
I'd like to update the copy of libsecp256k1-zkp as well to fix ElementsProject/rust-elements#202 and then yes, an update is a high priority. @jonasnick do you know what the relationship between libsecp and libsecp-zkp is right now? Can I just update the libsecp-zkp in this library to |
|
Yes I'd expect that updating libsecp-zkp in this library will work. Good point about the context object; it's identical in both forks of the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also do some other deferred maintenance.
Fixes #79.